Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Pull in containerd v1.3.0-beta.1 for the containerd client #348

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Pull in containerd v1.3.0-beta.1 for the containerd client #348

merged 2 commits into from
Aug 19, 2019

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Aug 19, 2019 •
edited
Loading

This pulls in the containerd package for the client in #337. Ignite has no previous dependency on containerd, so I added a placeholder to keep it from being removed during a tidy (and for CI to pass).

cc @luxas

@twelho twelho added kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 19, 2019
@twelho twelho added this to the v0.6.0 milestone Aug 19, 2019
@twelho twelho requested a review from luxas August 19, 2019 10:30
luxas
luxas approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@luxas luxas added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Aug 19, 2019
@luxas luxas merged commit fd39415 into weaveworks:master Aug 19, 2019
@twelho twelho deleted the bump-containerd branch August 19, 2019 10:40
@twelho twelho mentioned this pull request Aug 20, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luxas luxas luxas approved these changes

Assignees

@luxas luxas

Labels
area/dependency Issues or PRs related to dependency changes kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@twelho @luxas